-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading from the system journal #40
Draft
jabedude
wants to merge
1
commit into
lucab:master
Choose a base branch
from
jabedude:sdjournal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
use std::fs::File; | ||
use std::path::Path; | ||
|
||
use sdjournal::journal::*; | ||
use sdjournal::iter::EntryIter; | ||
|
||
use crate::errors::*; | ||
|
||
#[derive(Debug)] | ||
pub struct SdJournal { | ||
inner: Journal<File>, | ||
} | ||
|
||
impl SdJournal { | ||
pub fn open_journal<P: AsRef<Path>>(path: P) -> Result<Self> { | ||
let file = File::open(path)?; | ||
|
||
let journal = Journal::new(file)?; | ||
|
||
let sdjournal = SdJournal { | ||
inner: journal, | ||
}; | ||
|
||
Ok(sdjournal) | ||
} | ||
|
||
pub fn iter(&self) -> EntryIter<File> { | ||
self.inner.iter_entries() | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::*; | ||
|
||
#[test] | ||
fn test_sdjournal_read_simple() { | ||
let sd = SdJournal::open_journal("./tests/user-1000.journal"); | ||
assert!(sd.is_ok()); | ||
} | ||
|
||
#[test] | ||
fn test_sdjournal_iter_simple() { | ||
let sd = SdJournal::open_journal("./tests/user-1000.journal").unwrap(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we make this file a bit smaller, just containing a few entry objects? |
||
|
||
let mut counter = 0; | ||
|
||
let iter = sd.iter(); | ||
for _obj in iter { | ||
counter += 1; | ||
//eprintln!("obj: {}", obj.realtime); | ||
} | ||
|
||
// journalctl --header --file tests/user-1000.journal | grep "Entry Objects" == 645 | ||
assert_eq!(counter, 645); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a bit of API mismatch here. To the best of my knowledge, the C API never works on a single file in isolation. I think the closest to this is
sd_journal_open_files
, which would take a slice of paths instead.Perhaps we should start with an implementation of
sd_journal_open_files_fd
instead, and build the other ones of top of that?