Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product variant attributes can not be edited if product has no options #1996

Closed
AidasK opened this issue Oct 20, 2024 · 2 comments · Fixed by #2054
Closed

Product variant attributes can not be edited if product has no options #1996

AidasK opened this issue Oct 20, 2024 · 2 comments · Fixed by #2054
Assignees
Labels
bug Something isn't working confirmed

Comments

@AidasK
Copy link
Contributor

AidasK commented Oct 20, 2024

  • Lunar version: 1.0.0-beta3
  • Laravel Version: 10.48.22
  • PHP Version: 8.3.9
  • Database Driver & Version: Mysql

Expected Behaviour:

I should be able to fill in product variant attribute data event though product has only one product variant (e.g. it has no options)

Actual Behaviour:

I am not able to fill in any product variant attributes.

Steps To Reproduce:

  1. Assign some custom attributes to product variant.
  2. Create a product and you won't be able to fill in any custom attribute_data on product_variant.

On lunar 0.8 it was possible to fill in this data, not we can't. Solution might be to create same attributes for the product too, but it create additional code complexity as you must check two places for attributes in a product and in a product variant.

@glennjacobs
Copy link
Contributor

That's a good point, it should support that.

@fredmarmillod
Copy link
Contributor

fredmarmillod commented Mar 28, 2025

I've just tried on a fresh Lunar starterkit install and it works with Text or TranslatedText field types but others like Toggle or Number triggers a validation error. I'm using v1.0.0-beta17

Image

Steps to reproduce:

  1. Install Lunar starterkit
  2. Create a attribute group
  3. Add a Number field to the group
  4. Add the group to a product type
  5. Create a new product
  6. Try to save the product

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants