fix: saving single variant attribute from product page #2151
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @fredmarmillod Thanks for this, unfortunately it doesn't seem to fix the issue for me. I still get the validation error, which I agree is a problem 🤔 |
|
You're right, I've retried and it works only if the product type only has variant attributes configured. When we add product attributes, it triggers a validation error only for those. It seems like there is a conflict with the |
|
@alecritson The changes appear to be working correctly now. Could you please review the implementation and let me know if you notice any potential issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with single variant product attribute saving when attribute types are not Text or Translatable Text.
#1996 (comment)
Steps to reproduce:
Expected behavior:
The product should save successfully.
Actual behavior:
It triggers a validation error.