Remove enforced unique validation on SKU

[ryanmitchell]

This PR removes the enforced unique validation on SKU.

Dev's can overwrite the SKU validation using extendSkuValidation() hook, but the line removed in this PR still forces unique validation even when you don't want it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lunar-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 17, 2025 8:11am

[wychoong]

@ryanmitchell @alecritson i given a quick look, this doesnt seems to be the correct change

• there is no extendSkuValidation hook for ProductVariantResource

  lunar/packages/admin/src/Filament/Resources/ProductVariantResource.php

  Lines 86 to 89 in 2d0ac1c

  	public static function getSkuFormComponent(): Forms\Components\TextInput
  	{
  	return Forms\Components\TextInput::make('sku');
  	}

• this only removes when editing Product but not ProductVariant
  

  lunar/packages/admin/src/Filament/Resources/ProductVariantResource/Pages/ManageVariantIdentifiers.php

  Lines 59 to 64 in 2d0ac1c

  	ProductVariantResource::getSkuFormComponent()
  	->live()->unique(
  	table: fn () => $this->getRecord()->getTable(),
  	ignorable: $this->getRecord(),
  	ignoreRecord: true,
  	),

• currently extendSkuValidation only apply for creating new product in ListProducts
  

  lunar/packages/admin/src/Filament/Resources/ProductResource.php

  Lines 139 to 162 in 2d0ac1c

  	public static function getSkuValidation(): array
  	{
  	return static::callStaticLunarHook('extendSkuValidation', [
  	'required' => true,
  	'unique' => true,
  	]);
  	}
  	public static function getSkuFormComponent(): Component
  	{
  	$validation = static::getSkuValidation();
  	$input = Forms\Components\TextInput::make('sku')
  	->label(__('lunarpanel::product.form.sku.label'))
  	->required($validation['required'] ?? false);
  	if ($validation['unique'] ?? false) {
  	$input->unique(function () {
  	return (new ProductVariant)->getTable();
  	});
  	}
  	return $input;
  	}

  
  

  lunar/packages/admin/src/Filament/Resources/ProductResource/Pages/ListProducts.php

  Lines 36 to 48 in 2d0ac1c

  	public static function createActionFormInputs(): array
  	{
  	return [
  	Grid::make(2)->schema([
  	ProductResource::getBaseNameFormComponent(),
  	ProductResource::getProductTypeFormComponent()->required(),
  	]),
  	Grid::make(2)->schema([
  	ProductResource::getSkuFormComponent(),
  	ProductResource::getBasePriceFormComponent(),
  	]),
  	];
  	}

do let me know if I got it wrong

[alecritson]

@ryanmitchell No problem, I have reverted the change.

[ryanmitchell]

Ok, well the issue still stands, if you dont want unique SKUs currently the system still enforces that.

[alecritson]

Yes it will need to be revisited if the original PR didn't cover all use cases.