-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring search package into monorepo #2064
base: 1.x
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
i know this might be early. but can it play nicely with model extension? |
So the package doesn't return Product models, just what is from the index. I have been using it on a site with model extending and the only caveat for now is you may have to add your own model references to the search config alongside 'facets' => [
\Lunar\Models\Product::class => [],
\App\Models\Product::class => [],
] |
I think it should be handled like the indexer config. I’m not too sure if there is a use case for having both references 🤔 |
There's some area's in scout where the config is referenced directly so not sure how that could be overcome at the moment. |
This PR looks to introduce the new search package into the monorepo