Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring search package into monorepo #2064

Open
wants to merge 10 commits into
base: 1.x
Choose a base branch
from

Conversation

alecritson
Copy link
Collaborator

This PR looks to introduce the new search package into the monorepo

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 0:52am

@alecritson alecritson marked this pull request as ready for review January 16, 2025 12:42
@alecritson alecritson marked this pull request as draft January 16, 2025 12:44
@alecritson alecritson marked this pull request as ready for review January 16, 2025 13:06
@wychoong
Copy link
Contributor

i know this might be early. but can it play nicely with model extension?

@alecritson
Copy link
Collaborator Author

i know this might be early. but can it play nicely with model extension?

So the package doesn't return Product models, just what is from the index. I have been using it on a site with model extending and the only caveat for now is you may have to add your own model references to the search config alongside Lunar\Models\{class} e.g.

'facets' => [
    \Lunar\Models\Product::class => [],
    \App\Models\Product::class => [],
]

@wychoong
Copy link
Contributor

I think it should be handled like the indexer config. I’m not too sure if there is a use case for having both references 🤔

@alecritson
Copy link
Collaborator Author

I think it should be handled like the indexer config. I’m not too sure if there is a use case for having both references 🤔

There's some area's in scout where the config is referenced directly so not sure how that could be overcome at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants