Merge pull request #378 from lunasec-io/fix-file-not-closed

close reader which is left open in log4shell cli Former-commit-id: 569b46c Former-commit-id: 303d657fa85df7d55910e08a9c5b1b8f9fb88f00
lunasec-io · Dec 21, 2021 · a45854a · a45854a
2 parents e3859a4 + 7a3c71d
commit a45854a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/tools/log4shell/constants/version.go b/tools/log4shell/constants/version.go
@@ -14,4 +14,4 @@
 //
 package constants
 
-const Version = "1.4.1"
+const Version = "1.4.2"
diff --git a/tools/log4shell/scan/scan.go b/tools/log4shell/scan/scan.go
@@ -203,6 +203,8 @@ func (s *Log4jDirectoryScanner) scanArchiveFile(
 			Msg("unable to open class file")
 		return
 	}
+	defer reader.Close()
+
 	return s.processArchiveFile(reader, path, file.Name)
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -203,6 +203,8 @@ func (s *Log4jDirectoryScanner) scanArchiveFile( @@
     			Msg("unable to open class file")
     		return
     	}
+    	defer reader.Close()
     	return s.processArchiveFile(reader, path, file.Name)
     }
@@ Expand Down @@