Use main thread of current Lua state for callbacks, when known #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So currently this does not work for PUC Lua 5.1 and for LuaJIT? |
|
The behaviour will not change for Lua 5.1. I haven't tested with LuaJIT. If it implements |
|
Please add a test for this |
mwild1
force-pushed
the
fix/use-main-lua-thread
branch
from
1c64f6c
to
48ebde6
Compare
If the library is opened from a Lua thread (coroutine) that is not the main one, the stored L would be to that thread, which may become suspended (by calling yield). It is unsafe to call functions on suspended Lua threads, which luv does a lot (the stored L is used for callbacks). The main thread of a Lua state can never yield, so it is always safe to call callbacks on. This commit ensures the main thread is stored in the luv context instead of the current thread, when we are able to calculate it (LUA_RIDX_MAINTHREAD was added in Lua 5.2, and I have not found a way to determine the main thread in Lua 5.1). This fixes luvit#503
mwild1
force-pushed
the
fix/use-main-lua-thread
branch
from
48ebde6
to
ba4589c
Compare
|
I have added a test. It will definitely fail on Lua 5.1, and probably LuaJIT, so it is skipped there (test always passes, comment is printed). |
zhaozg
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the library is opened from a Lua thread (coroutine) that is not the main one, the stored L would be to that thread, which may become suspended (by calling yield). It is unsafe to call functions on suspended Lua threads, which luv does a lot (the stored L is used for callbacks).
The main thread of a Lua state can never yield, so it is always safe to call callbacks on.
This commit ensures the main thread is stored in the luv context instead of the current thread, when we are able to calculate it (LUA_RIDX_MAINTHREAD was added in Lua 5.2, and I have not found a way to determine the main thread in Lua 5.1).
This fixes #503