New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes build forcing during Lua load error #290

Merged

squeek502 merged 1 commit into luvit:master from SinisterRectus:fix-force

Jul 10, 2024

Member

SinisterRectus commented Jul 10, 2024 •

edited

Loading

Bug introduced in #276:

if compile and isLua and name:lower() ~= 'package.lua' then
  local fn, err = load(ctx, child)
  if not fn and not options.force then
    error(err)
  else
    ctx = string.dump(fn, options.strip)
  end
end

When load fails, fn is nil. If options.force is true, string.dump is called with nil and also fails.

This change removes the attempt to call string.dump with nil. Obviously, the resulting code will not be compiled or stripped in the bundle.


          Fixes build forcing during Lua load error

d3f578d

SinisterRectus added the bug label

Contributor

Bilal2453 commented Jul 10, 2024

Makes sense to me.

squeek502 approved these changes

View reviewed changes

squeek502 merged commit 938eb53 into luvit:master

50 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug