fix: add no-module
to openssl static build
#302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since the update to openssl 3.x we have been building static openssl ever so slightly incorrect. Without the
no-module
configuration option openssl still tries to provide some non-core modules (like the legacy provider) as a shared library. However luvi has no way to bundle this, and so ever since the update to openssl 3.x we have been unable to use any of the legacy ciphers in luvi.This was only observable by checking the list of openssl errors, because lua-openssl attempts to load both the default and legacy providers without handling any errors.
I used the following script to ensure the provided fix actually works for the legacy provider:
Before this fix:
After this fix:
Alongside fixing the static build of openssl, this also fixes the intermittent issue with lua-openssl triggering the incompatible pointer types error by silencing the warning for lua-openssl, which it does internally but only for clang.