Port network_load_balancers to database generator #2068
Conversation
davidbockelman
force-pushed
the
db-codegen-network-load-balancer
branch
from
d46395d to
49eaa2e
Compare
|
Hi @davidbockelman . Your pull request has been super helpful to me, guiding me on how to tackle the database generator issue I was assigned. I'm working on One thing I think you missed is calling As I'm working through mine and comparing against yours, I'll let you know if I find anything else. |
| for _, lb := range loadBalancers { | ||
| // memberSpecific requirements | ||
| if !memberSpecific || !lb.NodeID.Valid || (lb.NodeID.Valid && lb.NodeID.Int64 == tx.GetNodeID()) { | ||
| if projectNetworksLoadBalancersOnUplink[projectName] == nil { |
There was a problem hiding this comment.
Initialize projectNetworksLoadBalancersOnUplink = make(map[string]map[string][]string)
| if err != nil { | ||
| return nil, fmt.Errorf("Failed loading network forward listen addresses: %w", err) | ||
| return nil, fmt.Errorf("Failed loading network load balancer listen addresses: %w", err) |
There was a problem hiding this comment.
I'll be using this logic for retrieving the network forward listen addresses too, so maybe we can have it more generic like return nil, err?
| ListenAddress: loadBalancer.ListenAddress, | ||
| Description: loadBalancer.Description, | ||
| Backends: loadBalancer.Backends, | ||
| Ports: loadBalancer.Ports, |
There was a problem hiding this comment.
I think you should check these two fields if they're null or not, and assign Backends/Ports to []. Otherwise, I believe this messes up the JSON marshalling and unmarshalling.
stgraber
force-pushed
the
db-codegen-network-load-balancer
branch
from
9a10703 to
2bb65e9
Compare
|
Did a first pass of cleanup on this one. Other than some formatting issues and other static analysis stuff, this is looking pretty good. |
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: David Bockelman <[email protected]>
Signed-off-by: David Bockelman <[email protected]>
stgraber
force-pushed
the
db-codegen-network-load-balancer
branch
from
2bb65e9 to
3a811e0
Compare
Created
internal/server/db/cluster/networks_load_balancers.gowhich allows for the network_load_balancers SQL code to be auto-generated withmake update-schema. Changed the call sites to functions ininternal/server/db/network_load_balancers.goto use the new auto-generated functions. Functions ininternal/server/db/network_network_load_balancers.goare no longer used.Fixes #1800