Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Update golangci-lint to support go 1.24 #3265

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

carlos-cecnn12
Copy link
Contributor

@carlos-cecnn12 carlos-cecnn12 commented Mar 25, 2025

Description

While trying to update the codebase to go 1.24 we noticed the golangci-lint version was a bit outdated and causing some issues, updating it and ran make backend-lint and make backend-lint-fix to ensure the lint is correctly working again. While updating, also noticed lots of G115 exceptions in our backend / lint tests, so added a //nolint comment to avoid having a linter failure while we check each of the cases to see if it would cause an overflow.

Testing Performed

  • Successfully running make backend-lint

GitHub Issue

Fixes #

TODOs

  • Check for overflows in the int conversions followed by a //nolint comment

@carlos-cecnn12 carlos-cecnn12 marked this pull request as ready for review March 25, 2025 23:01
@carlos-cecnn12 carlos-cecnn12 requested a review from a team as a code owner March 25, 2025 23:01
@carlos-cecnn12 carlos-cecnn12 merged commit dc4d2f6 into main Mar 26, 2025
18 checks passed
@carlos-cecnn12 carlos-cecnn12 deleted the update-golangci-lint branch March 26, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants