implement mros2::setIPAddressRTPS to move its operation from config/rtps.h
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
confirmed!! mROS-base/mros2-mbed#42 (comment) |
takasehideki
added a commit
that referenced
this pull request
Sep 17, 2023
…ck whether network can be connected also check: #45
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, IP address settings were required in both
./include/config/rtps.hand inapp.cpp, but I could solve this situation so that it can work with only one setting, in./platform/mros2-platform.h.After the network configuration is complete, the program obtains the IP address and stores it to the configuration for embeddedRTPS (
rtps::Config::IP_ADDRESS). This may increase the implementation responsibility for each platform, but I believe it should be more convenient for the user.We have confirmed that this works only with mros2-mbed / echoback_string. Please check along with the following.
mROS-base/mros2-mbed#42