-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(addresses): add flag to incl from and to address #21
base: main
Are you sure you want to change the base?
Conversation
feat(address): add address flag
There should be documentation on how to enter an address like:
It looks like It looks like double quoting the string with the
So something to add to the documentation. |
I think using JSON file or a database connection for the information would be better. You have to include difference for different countries as well. |
pdf.go
Outdated
@@ -34,6 +35,15 @@ func writeLogo(pdf *gopdf.GoPdf, logo string, from string) { | |||
_ = pdf.SetFont("Inter", "", 12) | |||
pdf.SetTextColor(55, 55, 55) | |||
_ = pdf.Cell(nil, from) | |||
pdf.Br(18) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be extracted into another function and called here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in 67ff7f6 commit
refactor(review): update peer review
chore(review): update peer review comments
sorry for long absence updated in commit 30dd8de |
@maaslalani any updates here? |
#14