Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addresses): add flag to incl from and to address #21

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ehrktia
Copy link

@ehrktia ehrktia commented Jul 1, 2023

#14

karthick ayyapillai added 2 commits July 1, 2023 18:37
@ehrktia ehrktia mentioned this pull request Jul 1, 2023
@rouilj
Copy link

rouilj commented Jul 3, 2023

There should be documentation on how to enter an address like:

1625 Beech St
Suite 2201
New York, New York 10014

It looks like , is always consumed. I tried using ',` to allow it to pass through but it still resulted in a new line.

It looks like double quoting the string with the , works.

--from-address '"1865 N Charlotte st",Suite32,"Nothaman, SN 02317"'
--to-address "135 Wehawken St.,\"Raleigh, NC 34217\""

So something to add to the documentation.

@raguay
Copy link

raguay commented Jul 4, 2023

I think using JSON file or a database connection for the information would be better. You have to include difference for different countries as well.

pdf.go Outdated
@@ -34,6 +35,15 @@ func writeLogo(pdf *gopdf.GoPdf, logo string, from string) {
_ = pdf.SetFont("Inter", "", 12)
pdf.SetTextColor(55, 55, 55)
_ = pdf.Cell(nil, from)
pdf.Br(18)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be extracted into another function and called here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 67ff7f6 commit

@ehrktia
Copy link
Author

ehrktia commented Jul 15, 2023

There should be documentation on how to enter an address like:

1625 Beech St
Suite 2201
New York, New York 10014

It looks like , is always consumed. I tried using ',` to allow it to pass through but it still resulted in a new line.

It looks like double quoting the string with the , works.

--from-address '"1865 N Charlotte st",Suite32,"Nothaman, SN 02317"'
--to-address "135 Wehawken St.,\"Raleigh, NC 34217\""

So something to add to the documentation.

sorry for long absence updated in commit 30dd8de

@MalteKiefer
Copy link

@maaslalani any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants