Skip to content

Commit

Permalink
fix: ignore of shownByDefault on left sidebar (#532)
Browse files Browse the repository at this point in the history
Co-authored-by: Adrian Samoticha <[email protected]>
  • Loading branch information
ShayperCool and Adrian-Samoticha authored Jan 27, 2025
1 parent 1824206 commit faea7a0
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## [2.1.8]
### 🛠️ Fixed 🛠️
* Fixed `shownByDefault` not being respected for the left sidebar of the `MacosWindow` (thanks, [@ShayperCool](https://github.com/ShayperCool)).

## [2.1.7]
### 🔄 Updated 🔄
* Expose `WindowMainStateListener` and implement `overrideIsMainWindow` method to allow for the window’s main state to be overridden.
Expand Down Expand Up @@ -28,7 +32,6 @@
* pubspec.yaml allows Flutter SDK version 1.9.x, which does not support the flutter.plugin.platforms key.
Please consider increasing the Flutter SDK requirement to ^1.10.0 (environment.sdk.flutter)
```

## [2.1.1]
* Fixed a bug where `MacosPulldownMenuItem` would not show an alert dialog when tapped.

Expand Down
2 changes: 1 addition & 1 deletion example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ packages:
path: ".."
relative: true
source: path
version: "2.1.4"
version: "2.1.8"
macos_window_utils:
dependency: transitive
description:
Expand Down
2 changes: 1 addition & 1 deletion lib/src/layout/window.dart
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class _MacosWindowState extends State<MacosWindow> {
double _endSidebarWidth = 0.0;
double _endSidebarDragStartWidth = 0.0;
double _endSidebarDragStartPosition = 0.0;
bool _showSidebar = true;
late bool _showSidebar = widget.sidebar?.shownByDefault ?? true;
late bool _showEndSidebar = widget.endSidebar?.shownByDefault ?? false;
int _sidebarSlideDuration = 0;
SystemMouseCursor _sidebarCursor = SystemMouseCursors.resizeColumn;
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: macos_ui
description: Flutter widgets and themes implementing the current macOS design language.
version: 2.1.7
version: 2.1.8
homepage: "https://macosui.dev"
repository: "https://github.com/GroovinChip/macos_ui"

Expand Down

0 comments on commit faea7a0

Please sign in to comment.