minetest rev2 - Portfile w/ variants #17153

Zweihorn · 2023-01-01T11:26:38Z

This PR was made obsolete by #17241

Description

Update Profile of MT 5.6.1 "minetest" rev2 with new variants and some improvements
Introduce new variants: [+]GLES, arm64, benchmark, debug, gprof, noclient, psql, server
Continue legacy-os: Mac OS X 10.6 Snow Leopard platform (requires bugfix in update of "irrlichtmt")

Ref https://trac.macports.org/ticket/66439
Ref https://trac.macports.org/ticket/66599
Ref https://trac.macports.org/ticket/66600

The b.m. Trac ticket should not hinder any review and is an independent activity by same maintainer:

ref https://trac.macports.org/ticket/66610

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 11.7.2 20G1020 x86_64
Command Line Tools 13.2.0.0.1.1638488800

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?
checked your Portfile with port lint --nitpick?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?
checked that the Portfile's most important variants haven't been broken?

Future tasks:

Postpone "irrlichtmt" update (upstream IrrLichtMT 1.9.0mt9; 2022-12-29) in hope of legacy-os support
Consider feasibility of sub-port "minetest-devel" only after MT 5.7.0 upstream.

Ref https://github.com/minetest/irrlicht/compare/1.9.0mt8...1.9.0mt9
~~Ref to a.m. MT forum topic with preliminary MT 5.7 schedule~~ seems to be lost or deleted

Hope this helps.

🌻

mckaygerhard · 2023-01-01T19:48:06Z

hi @Zweihorn noted you get into MT world recently.. porting minetest from trolltest is not so valuable.. i recommend to you porting multicraft or final minetest real code that permit to work in both 0.4 and 5.X servers ..

if not using this is not so valuable cos mayority of players use phones that are rulez by multicraft forks.. (and not multicraft per se that is a crap also)

mckaygerhard · 2023-01-01T19:51:03Z

also mac OS 10 must be included so, cos multicraft already compiles with older irrlilcht 1.8.X so the error of https://trac.macports.org/ticket/66439 is not happened.. i am playing with a minetest/multicraft mixed build using 1.8 irrlincht

Zweihorn · 2023-01-01T20:12:08Z

hi @Zweihorn noted you get into MT world recently.. porting minetest from trolltest is not so valuable.. i recommend to you porting multicraft or final minetest real code that permit to work in both 0.4 and 5.X servers ..

if not using this is not so valuable cos mayority of players use phones that are rulez by multicraft forks.. (and not multicraft per se that is a crap also)

@mckaygerhard - Have a look at earlier discussion in the MT forum at How can we convince more players of Minetest?

Contrary to your approach I fully agree with one 'Tuxilio' and my old friend 'snoopy' and let it put me like this:

We are in the MacPorts repository for Minetest, not for Multicraft.
If I wanted to promote Multicraft, I would write it in their domain.

Zweihorn · 2023-01-01T20:24:19Z

also mac OS 10 must be included so, cos multicraft already compiles with older irrlilcht 1.8.X so the error of https://trac.macports.org/ticket/66439 is not happened.. i am playing with a minetest/multicraft mixed build using 1.8 irrlincht

@mckaygerhard - THX for pointing this, but I am not the maintainer of the "irrlichtmt" port. Naturally the "irrlichtmt" port is a dependency to this "minetest" port.

I would agree with you, how unfortunate the momentary drop from the most beloved Mac OS X 10.6 Snow Leopard legacy platform would be. Unfortunately, I could detect no technical details added by you to improve this little mishap.

However, I find your now argument quite contradictory to your a.m. claim "majority of players use phones" or did I misunderstand you somehow?

mckaygerhard · 2023-01-01T21:16:47Z

also mac OS 10 must be included so, cos multicraft already compiles with older irrlilcht 1.8.X so the error of https://trac.macports.org/ticket/66439 is not happened.. i am playing with a minetest/multicraft mixed build using 1.8 irrlincht
@mckaygerhard - THX for pointing this, but I am not the maintainer of the "irrlichtmt" port. Naturally the "irrlichtmt" port is a dependency to this "minetest" port.

is not necessary.. in fact the multicraft compiles with any version of already ported irrlicht package

I would agree with you, how unfortunate the momentary drop from the most beloved Mac OS X 10.6 Snow Leopard legacy platform would be. Unfortunately, I could detect no technical details added by you to improve this little mishap.

current world economy is not the best .. on thing is that developers said and another the crude hole word reality.. in fact i only have a 2011 MAC and for no reason i will spend more money in another pretty EXPENSIVE mac so maybe in future macports will decrease the usage.. with linux inclusion inside windows as subsystem

However, I find your now argument quite contradictory to your a.m. claim "majority of players use phones" or did I misunderstand you somehow?

do you play or are just a "almost" player like rubenwardy.. ? i played as a crude warrior.. if you code .. i guess never will play seriously unless you play "survivals" boring servers .. most "rare" servers are hosted hidden and not use the minetest list, phone users are mostly from latam (huge amount) or asia-russia

or more easy: look around from "minecraft-like" apps in google apps store 😆

Zweihorn · 2023-01-01T21:55:44Z

#17161

Zweihorn · 2023-01-02T09:35:39Z

@reneeotten - IMO it would be good to have this PR i.e. the "minetest" rev2 approved before I dig into the upcoming "irrlcihtmt" upstream update and possible issus with the "minetest" port API.

Zweihorn · 2023-01-02T16:02:59Z

minetest/irrlicht#152

Zweihorn · 2023-01-03T08:24:57Z

Will amend the Portfile and remove the 'darwin >= 11' in particular.

Thanks to kind advice from @sfan5 there seems to be hope for Mac OS X 10.6 and Minetest.

amend Profile w/ Mac OS X 10.6 support update Portfile --> 3rd squash for rev2 * revision 2 - ready for review * platforms darwin * new variants: [+]GLES, arm64, benchmark, debug, prof, noclient, psql, server * default MESA & GLES support * introduce new variants as follows: + arm64 - known to fail - WIP + benchmark - adds UnitTest & Bechmarks + debug - make a MT Debug build + GLES - specific MESA & GLES graphical support + gprof - optional gprof profiler (needs GCC) + noclient - drops MT client + psql - PostgresQL13 support + server - dedicated MT server * WIP - move `minetestserver` into `/opt/local/bin` * platforms darwin - (again, depends on "irrlichtmt" foreseeable support for Mac 10.6 in future queue) * new benchmark variant was renamed from test * drop devel variant (stub) for future subport(s) * correction: debug conflicts benchmark (i.e. reanamed test) * correction: server no conflict (i.e. devel was removed)

Zweihorn · 2023-01-03T20:40:00Z

PR is READY for review

MT 5.6.1 rev2 - (2nd round)

Introduce new variants: [+]GLES, arm64, benchmark, debug, gprof, noclient, psql, server

Zweihorn · 2023-01-06T08:40:49Z

Please review

The b.m. Trac ticket should not hinder any review and is an independent activity by same maintainer:

ref https://trac.macports.org/ticket/66610

Zweihorn · 2023-01-07T18:03:31Z

Hmm - something went wrong with this branch and squash, apparently. Still learning and not loving git.

Zweihorn · 2023-01-07T18:06:12Z

The combined build and install has no problems with the new & amended 'irrlichtmt' API and 'minetest' was installed without any error.


% sudo port -kvst install 2>&1 | tee ../minetest-install01.log

. . .
x ./opt/macports-test/Applications/minetest.app/Contents/MacOS/minetestserver
x ./opt/macports-test/Applications/minetest.app/Contents/MacOS/minetest
--->  Updating database of binaries
--->  Scanning binaries for linking errors
--->  No broken files found.
--->  No broken ports found.


% port info
irrlichtmt @1.9.0mt9 (devel)
Variants:             debug, universal

Description:          IrrlichtMt is a fork of Irrlicht by the Minetest developers.
Homepage:             https://github.com/minetest/irrlicht

Build Dependencies:   cmake
Library Dependencies: libjpeg-turbo, libpng, zlib
Platforms:            darwin
License:              zlib
Maintainers:          Email: [email protected], GitHub: l2dy
                      Policy: openmaintainer


% port info

minetest @5.6.1_2 (games)
Variants:             [+]GLES, arm64, benchmark, debug, gprof, noclient, psql, server

Description:          open source infinite-world block sandbox game with survival and crafting - Find more MT mods at <https://content.minetest.net/> and have fun.
Homepage:             https://www.minetest.net

Build Dependencies:   cmake, doxygen, mesa
Library Dependencies: irrlichtmt, libjpeg-turbo, libogg, libvorbis, freetype, gettext, leveldb, sqlite3, zstd, luajit, gmp, curl, jsoncpp, spatialindex, xorg-libX11,
                      xorg-libXxf86vm
Platforms:            darwin
License:              LGPL-2.1+
Maintainers:          GitHub: Zweihorn
                      Policy: openmaintainer

Zweihorn · 2023-01-07T18:39:32Z

IMO there will be a new PR hopefully addressing this git chaos anew...

Hold your breath.

kencu · 2023-01-07T19:20:57Z

please -- no variants, or at least not so many. It's a game; people just want it to work.

Go ahead as an expert, and set the build the way people should have it, and make it easy for folks.... variants are killers, nobody (hardly) ever tests anything but the default builds of anything.

Zweihorn · 2023-01-07T20:19:39Z

please -- no variants, or at least not so many. It's a game; people just want it to work.

Go ahead as an expert, and set the build the way people should have it, and make it easy for folks.... variants are killers, nobody (hardly) ever tests anything but the default builds of anything.

THX

In hindsight there should be sub-ports and let me elaborate on the three use cases as:

"minetest" - MT client & MT server (App) - +GLES - (ready with new fixes)
"minetest-server" - dedicated MT server (CLI) - +psql, noclient (would completely drop 1, irrlichtmt and App) - (WIP)
"minetest-devel" - dev & expert - benchmarks, debug, gprof - (ready)

MacPorts apparently has a default on debug as standard requirement? Correct?

Certainly, I will drop +arm64 as this can be always detected from the arch (and I did already).

Furthermore, the binding between MT 5.6.1 / MT 5.6.x with irrlichtmt8 and presumably MT 5.7.x with irrlichtmt9 is extra concern for versioning.

"minetest" & "minetest-server" & "minetest56" & "minetest56-server" - MT 5.6.1+
"minetest57" & "minetest57-server" - MT 5.7.0+

macportsbot added maintainer maintainer: open Affects an openmaintainer port type: enhancement labels Jan 1, 2023

Zweihorn changed the title ~~minetest rev2 (draft) 02 enhance~~ minetest rev2 - Portfile w/ variants Jan 1, 2023

Zweihorn marked this pull request as ready for review January 1, 2023 19:14

Zweihorn mentioned this pull request Jan 1, 2023

Update minetest rev2 (draft) 01 #17151

Closed

12 tasks

Zweihorn mentioned this pull request Jan 2, 2023

irrlichtmt: update #17161

Closed

10 tasks

Zweihorn marked this pull request as draft January 3, 2023 08:21

Zweihorn marked this pull request as ready for review January 3, 2023 20:37

Zweihorn mentioned this pull request Jan 7, 2023

OpenGL 3.2 symbol breaks install on legacy macOS minetest/irrlicht#152

Open

Zweihorn closed this Jan 7, 2023

Zweihorn deleted the minetest_rev2_002 branch January 7, 2023 18:44

Zweihorn mentioned this pull request Jan 7, 2023

minetest rev2 & fix irrlicht 1.9.0mt8 #17241

Closed

11 tasks

Zweihorn mentioned this pull request Jan 9, 2023

minetest: amend for subports #17258

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

minetest rev2 - Portfile w/ variants #17153

minetest rev2 - Portfile w/ variants #17153

Zweihorn commented Jan 1, 2023 •

edited

Loading

mckaygerhard commented Jan 1, 2023

mckaygerhard commented Jan 1, 2023

Zweihorn commented Jan 1, 2023 •

edited

Loading

Zweihorn commented Jan 1, 2023

mckaygerhard commented Jan 1, 2023 •

edited

Loading

Zweihorn commented Jan 1, 2023

Zweihorn commented Jan 2, 2023

Zweihorn commented Jan 2, 2023

Zweihorn commented Jan 3, 2023 •

edited

Loading

Zweihorn commented Jan 3, 2023

Zweihorn commented Jan 6, 2023

Zweihorn commented Jan 7, 2023

Zweihorn commented Jan 7, 2023 •

edited

Loading

Zweihorn commented Jan 7, 2023

kencu commented Jan 7, 2023

Zweihorn commented Jan 7, 2023 •

edited

Loading

minetest rev2 - Portfile w/ variants #17153

minetest rev2 - Portfile w/ variants #17153

Conversation

Zweihorn commented Jan 1, 2023 • edited Loading

Description

Type(s)

Tested on

Verification

Future tasks:

mckaygerhard commented Jan 1, 2023

mckaygerhard commented Jan 1, 2023

Zweihorn commented Jan 1, 2023 • edited Loading

Zweihorn commented Jan 1, 2023

mckaygerhard commented Jan 1, 2023 • edited Loading

Zweihorn commented Jan 1, 2023

Zweihorn commented Jan 2, 2023

Zweihorn commented Jan 2, 2023

Zweihorn commented Jan 3, 2023 • edited Loading

Zweihorn commented Jan 3, 2023

Zweihorn commented Jan 6, 2023

Zweihorn commented Jan 7, 2023

Zweihorn commented Jan 7, 2023 • edited Loading

Zweihorn commented Jan 7, 2023

kencu commented Jan 7, 2023

Zweihorn commented Jan 7, 2023 • edited Loading

Zweihorn commented Jan 1, 2023 •

edited

Loading

Zweihorn commented Jan 1, 2023 •

edited

Loading

mckaygerhard commented Jan 1, 2023 •

edited

Loading

Zweihorn commented Jan 3, 2023 •

edited

Loading

Zweihorn commented Jan 7, 2023 •

edited

Loading

Zweihorn commented Jan 7, 2023 •

edited

Loading