Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-shiboken: revert breakage introduced by C++11 requirement #26882

Closed
wants to merge 1 commit into from

Conversation

barracuda156
Copy link
Contributor

Description

C++11 was added as a hack around a reported build failure. However, it breaks the build with gcc-4.2, and on PowerPC clangs do not exist.
While it is unclear what exactly is at fault, at least revert the breaking change for PowerPC, so that the port can build normally.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@kencu
Copy link
Contributor

kencu commented Dec 6, 2024

the build error is likely nothing to do with ppc

the c++11 requirement can almost certainly be completely removed.

newer python versions should be added

the portfile looks like it needs a general cleanup as there is lots of sketchy stuff going on setting stuff unnecessarily…

after we finish with the gcc14 upgrade I’ll see if I can find some time to clean all this up

@kencu
Copy link
Contributor

kencu commented Dec 10, 2024

we do have to make sure we understand:

https://trac.macports.org/ticket/59622

Somewhere I found a comment after a commit that Josh said libxml2 had been updated and so c++11 might not be needed any longer. I'm still looking for that comment just now to make sure I have it right.

@barracuda156
Copy link
Contributor Author

This takes forever, I gonna just close it, let it be broken.

@barracuda156 barracuda156 deleted the shiboken branch January 12, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants