Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-rich-theme-manager: add Python 3.13 subport #26962

Closed
wants to merge 2 commits into from

Conversation

breun
Copy link
Member

@breun breun commented Dec 7, 2024

Description

Add Python 3.13 subport.

Tested on

macOS 15.1.1 24B91 arm64
Xcode 16.1 16B40

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added maintainer: none by: member Created by a member with commit rights labels Dec 7, 2024
@reneeotten
Copy link
Contributor

@breun there are missing dependencies

@breun
Copy link
Member Author

breun commented Dec 7, 2024

I'll rerun the jobs when those are merged. I expected them to be merged quickly, but GitHub Actions seems very slow recently.

@reneeotten
Copy link
Contributor

@breun you need to do a “rebase” as not to get merge commits

@breun
Copy link
Member Author

breun commented Dec 10, 2024

@reneeotten I'm used to working with GitLab, where I can type /rebase and it's all done. I found a button in the GitHub UI to 'sync' the branch, but apparently that did a merge instead of a rebase. Do you know if GitHub provides a way to rebase a branch, or does it need to be done manually locally?

@breun
Copy link
Member Author

breun commented Dec 10, 2024

I think I'll just redo this PR as well, the Python 3.8 subport also needs to be removed because py38-rich was removed.

@reneeotten
Copy link
Contributor

Best advice is to use the command line instead of the GitHub web interface

@breun
Copy link
Member Author

breun commented Dec 10, 2024

Second attempt: #27022

@breun breun closed this Dec 10, 2024
@breun breun deleted the py313-rich-theme-manager branch December 10, 2024 13:50
@reneeotten
Copy link
Contributor

or you can do a "squash-and-merge" and update the commit message from the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: none
Development

Successfully merging this pull request may close these issues.

3 participants