Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql17: update to 17.2 #26973

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

ecbrown
Copy link
Contributor

@ecbrown ecbrown commented Dec 7, 2024

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@barracuda156 for port postgresql17-server, postgresql17.
@dgilman for port postgresql17-server, postgresql17.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Dec 7, 2024
@barracuda156
Copy link
Contributor

Just in case, have the patches been confirmed to apply? One does not need a powerpc machine to check it, just drop conditional macro locally and run sudo port -v patch.

@ecbrown
Copy link
Contributor Author

ecbrown commented Dec 7, 2024

Just in case, have the patches been confirmed to apply? One does not need a powerpc machine to check it, just drop conditional macro locally and run sudo port -v patch.

I operated on a clone of macports-ports, and am now running 17.2 on my development machine M1. Seems fine. (I did not apply the patch in the way you suggest.)

@barracuda156
Copy link
Contributor

Any arch will do, since you are not supposed to confirm the build on any system besides required by CI. I mean just to verify if existing patches can still apply successfully. (That requires to enable them manually – on a local machine.)
I mean these:

platform darwin powerpc {
patchfiles-append patch-icu.diff \
patch-fix-ppc-asm.diff
}
(or whichever happen to be in a given port at the moment).

But anyway, to save your time, yes, they do apply:

--->  Applying patches to postgresql17
--->  Applying patch-icu.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_databases_postgresql17/postgresql17/work/postgresql-17.2" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/databases/postgresql17/files/patch-icu.diff'
patching file 'src/include/utils/pg_locale.h'
patching file 'src/backend/utils/adt/formatting.c'
--->  Applying patch-fix-ppc-asm.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_databases_postgresql17/postgresql17/work/postgresql-17.2" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/databases/postgresql17/files/patch-fix-ppc-asm.diff'
patching file configure
patching file configure.ac
patching file 'src/include/pg_config.h.in'
patching file 'src/include/pg_config_manual.h'
patching file 'src/include/port/atomics/arch-ppc.h'
patching file 'src/include/storage/s_lock.h'

@reneeotten reneeotten merged commit 6b0121c into macports:master Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
Development

Successfully merging this pull request may close these issues.

5 participants