Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python314-devel: add compatibility patches for macOS < 10.15 #26974

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 10K549 x86_64
Xcode 4.2 4C199

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@jmroot for port python314-devel.

@jmroot
Copy link
Member

jmroot commented Dec 11, 2024

Have you reported these upstream?

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

@jmroot no, also I don't see them wanting to support legacy versions of macOS.

@barracuda156
Copy link
Contributor

@jmroot no, also I don't see them wanting to support legacy versions of macOS.

As usual, people are just unaware that both buildbots and users exist.
image

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

I think I need to do a PRs in the HACL* and KaRaMeL repositories first.

@jmroot
Copy link
Member

jmroot commented Dec 12, 2024

@jmroot no, also I don't see them wanting to support legacy versions of macOS.

The installers are still nominally built for 10.13+, so they should care about < 10.15 even if they don't care about < 10.9. Things often break in prereleases and I've found they will often accept PRs for regressions on older versions during the alpha period, provided they don't add complexity. These patches are of course not in a form that would be accepted currently.

I'm really not keen on maintaining a patch set forever, so please make the effort with getting fixes in upstream.

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

Made patches unconditional and written as they would be sent to upstream repositories.
@jmroot @barracuda156

@barracuda156
Copy link
Contributor

@aeiouaeiouaeiouaeiouaeiouaeiou I have no control over what is merged here, but I will run the build on 10.6 from your PR today (adding a correct patch for pthread_threadid_np) and let you know if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants