-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bash: update to 5.2 patch 37, bash-devel: new port #26989
base: master
Are you sure you want to change the base?
Conversation
Notifying maintainers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to bash @5.2 looks good to me. Thank you for the port update!
Some minor details on the bash-devel port in an inline comment. However, I wonder whether it is really worth to add this port, as I assume the interested audience would be quite small.
Sorry, only now I finally realized you want to add bash-devel to fix the infamous bug with gettext. Yes, that seems enough to justify adding a new port. |
Date as the version number is a good idea. Not sure why it is failing on CI, I am going to try forcing it to use MP bison |
@@ -264,7 +294,7 @@ if {${subport} eq ${name}} { | |||
patchfiles-append patch-configure.diff | |||
} | |||
|
|||
depends_build bin:bison:bison \ | |||
depends_build port:bison \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change, is the macOS provided bison not sufficient to build it, as it apparently was in the past?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This doesn't have a fix for https://trac.macports.org/ticket/68638 . I made an initial attempt to cherry-pick that patch but it seemed hairy enough it's probably not worth maintaining.
But, to throw the affected a bone, I have added the bash-devel port that pulls in the latest devel branch. The fix is not in the 5.3-alpha release.
I didn't put this in as a Closes: because it doesn't really close the issue but can be persuaded if anyone feels strongly.
Type(s)
Tested on
macOS 14.6.1 23G93 x86_64
Xcode 16.1 16B40
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?