Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: update to 5.2 patch 37, bash-devel: new port #26989

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dgilman
Copy link
Contributor

@dgilman dgilman commented Dec 8, 2024

Description

This doesn't have a fix for https://trac.macports.org/ticket/68638 . I made an initial attempt to cherry-pick that patch but it seemed hairy enough it's probably not worth maintaining.

But, to throw the affected a bone, I have added the bash-devel port that pulls in the latest devel branch. The fix is not in the 5.3-alpha release.

I didn't put this in as a Closes: because it doesn't really close the issue but can be persuaded if anyone feels strongly.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.6.1 23G93 x86_64
Xcode 16.1 16B40

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@raimue for port bash.

@dgilman dgilman changed the title bash: update to 5.3 patch 37, bash-devel: new port bash: update to 5.2 patch 37, bash-devel: new port Dec 8, 2024
Copy link
Member

@raimue raimue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to bash @5.2 looks good to me. Thank you for the port update!

Some minor details on the bash-devel port in an inline comment. However, I wonder whether it is really worth to add this port, as I assume the interested audience would be quite small.

shells/bash/Portfile Outdated Show resolved Hide resolved
@raimue
Copy link
Member

raimue commented Dec 8, 2024

Some minor details on the bash-devel port in an inline comment. However, I wonder whether it is really worth to add this port, as I assume the interested audience would be quite small.

Sorry, only now I finally realized you want to add bash-devel to fix the infamous bug with gettext. Yes, that seems enough to justify adding a new port.

@dgilman
Copy link
Contributor Author

dgilman commented Dec 9, 2024

Date as the version number is a good idea. Not sure why it is failing on CI, I am going to try forcing it to use MP bison

@@ -264,7 +294,7 @@ if {${subport} eq ${name}} {
patchfiles-append patch-configure.diff
}

depends_build bin:bison:bison \
depends_build port:bison \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change, is the macOS provided bison not sufficient to build it, as it apparently was in the past?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants