Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-benchmark: new package #27011

Merged
merged 1 commit into from
Dec 10, 2024
Merged

google-benchmark: new package #27011

merged 1 commit into from
Dec 10, 2024

Conversation

glebm
Copy link
Contributor

@glebm glebm commented Dec 9, 2024

Description

Adds a package for https://github.com/google/benchmark

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

Component versions: DevToolsCore-798.0; DevToolsSupport-794.0

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

/cc @AJenbo

@kencu
Copy link
Contributor

kencu commented Dec 10, 2024

Generally speaking, macports as a policy always wants the shared library version installed if there is a choice. That way all the consumers of the library don't have to be rebuilt for every small change in the library, only for big ABI-changing updates.

If there is some reason why the static lib version is a better choice, and there may be, that is OK, but usually needs a bit of explanation.

@glebm
Copy link
Contributor Author

glebm commented Dec 10, 2024

Got you. I had simply cargo-culted this from gtest. Now changed to build a shared library by default along with a static variant.

@glebm
Copy link
Contributor Author

glebm commented Dec 10, 2024

On Tiger, linking to the resulting library fails in the same way as gtest (https://trac.macports.org/ticket/71511)

@kencu kencu merged commit c77be39 into macports:master Dec 10, 2024
3 checks passed
@glebm glebm deleted the google-benchmark branch December 10, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants