-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maven4: new submission #27040
base: master
Are you sure you want to change the base?
maven4: new submission #27040
Conversation
It looks like you'll want to disable jline native support, if possible. Or if not, delete the directory tree |
@mascguy I guess I could delete non-aarch64 files on aarch64, non-x86_64 files on x86_64, non-Mac files on Mac, non-Linux files on Linux, etc., but that would just result in a whole bunch of extra logic and platform-specific variants. I don't really see the value of that, and the whole |
Right, but we're including binaries, and we shouldn't. Even if upstream includes it by default, that doesn't mean we should. And the port is marked |
PortGroup java 1.0 | ||
|
||
name maven4 | ||
version 4.0.0-rc-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend using a version of 3.9.9-rc1 instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be kind of confusing, because Maven 3.9.9 is the current Maven 3 release. Do you mean that MacPorts' versioning considers 4.0.0-rc-1 newer than 4.0.0? If so, is there no other postfix that would make MacPorts consider it a version before 4.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 3.9.9-rc1 isn't a big deal. Plus the ultimate 4.0 release may be out before long.
I've added a |
We shouldn't be including any binaries, ever, when a port is marked Beyond that, upstream's macOS binaries probably target a fairly recent release, like Big Sur or later. Which means the readline native library is going to fail to load for users on 10.15 and earlier, resulting in Trac tickets for a broken port. Please please remove all of the native binaries, across-the-board... |
This port is no longer marked as
Deleting all native binaries seems like a pretty invasive modification to me. How can we be sure that it's safe to delete all of them and that this doesn't break anything? |
Description
New port for Apache Maven 4.
Tested on
macOS 15.2 24C101 arm64
Xcode 16.1 16B40
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?