Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scamper: Hotfix to fix building on < 10.7 #27057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheRealKeto
Copy link
Contributor

@TheRealKeto TheRealKeto commented Dec 13, 2024

Description

Apply hotfix to fix building scamper on < OSX 10.7, per this Trac ticket

Tested on

macOS 13.6 22G120 arm64
Command Line Tools 14.3.1.0.1.1683849156

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -d install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@matthewluckie for port scamper.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Dec 13, 2024
@barracuda156
Copy link
Contributor

It also needs a fix for AI_NUMERICSERV like in: 976522a

Otherwise:

scamper_control.c: In function ‘remote_connect’:
scamper_control.c:3801: error: ‘AI_NUMERICSERV’ undeclared (first use in this function)
scamper_control.c:3801: error: (Each undeclared identifier is reported only once
scamper_control.c:3801: error: for each function it appears in.)
make[2]: *** [scamper-scamper_control.o] Error 1
make[2]: *** Waiting for unfinished jobs....

Copy link
Contributor

@barracuda156 barracuda156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could add a patch here, it would be great (as it also relates to < 10.7).

@matthewluckie
Copy link

Thanks, I can do. Is there a howto on testing ports on older OSes?

@barracuda156
Copy link
Contributor

@matthewluckie Not really, I guess. It is fairly easy to install pretty much any macOS version in a VM though on an x86_86 hardware. (Building for PowerPC would require everything from scratch, but otherwise pre-built ports are there.) Also port status will show failures on buildbots (if any), so that can be used to see if builds work (since no buildbots for < 10.6 or any PowerPC, those can’t be checked this way).

@TheRealKeto
Copy link
Contributor Author

@barracuda156 This is provided by legacy-support, so shouldn't this port just use the legacysupport PG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port
Development

Successfully merging this pull request may close these issues.

4 participants