qmake5 PortGroup: do not include unneeded legacysupport #27297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building qt5-qttools fails (ticket, logs) on Mojave and High Sierra with a cryptic message:
It looks like the problem goes away when I remove
-isystem/opt/local/include/LegacySupport
from the compiler invocation. qt5-qttools does not use legacysupport itself. legacysupport is brought in by qmake5-1.0.tcl, which does not seem to make any use of it. Removing legacysupport from qmake5-1.0.tcl fixes the build, at least on Mojave.Type(s)
Tested on
macOS 10.14.6 18G9323 x86_64
Command Line Tools 10.3.0.0.1.1562985497
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?