Enable search dialog #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As search dialog and HildonLiveSearch are just different tools, it may be worth to re-enable search dialog.
LiveSearch only looks for words that start with search string while search dialog looks for any occurence.
If you type "photo" in livesearch prompt only PhotoLightMeter will appear, if you are looking for PhotoLightMeter it is ok. But if you want to find anything related to "photo" (or MihPhoto) you may want to use search dialog.
Also Synaptic contains both searches, the main and the prefix-based to filter search results. Let's not lag behind.