Issue 47 #71
Open
Issue 47 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some conditions, Atom enables the 'atom-text-editor' context-menu, even though the active Pane item is not a TextEditor instance. In this circumstance, @OpenEditor can be called, but workspace.getActiveTextEditor() will return 'undefined'. This commit introduces a sanity check against this case and also changes the flow of control to prevent the error from propagating.
getFilePath() is expected to return a String, but this is not guaranteed. [TextEditor.getPath()](https://atom.io/docs/api/v1.34.0/TextEditor#instance-getPath) returns `undefined` if the backing TextBuffer has never been saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #47 by adding a sanity-check for circumstances where Workspace.getActiveTextEditor() or TextEditor.getPath() returns
'undefined'. It also changes the flow of control to prevent exceptions from propagating up the call stack.