-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Magento reorder order id issue #39399
base: 2.4-develop
Are you sure you want to change the base?
Fixed Magento reorder order id issue #39399
Conversation
Hi @magentoabu. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run Static Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @magentoabu,
Thanks for the contribution!
Please sign the CLA as it is required to process the PR further. Till the time we are moving this PR On Hold
.
Thanks
CLA signed, please proceed further |
@magento run Static Tests |
Hello @magentoabu, It is still showing as unsigned. Please have a look at the cross mark in front of the Thanks |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @magentoabu,
Thanks for the contribution!
Please add an automated test in accordance to the DOD.
And also look into the below review comment.
Thanks
@@ -1,6 +1,6 @@ | |||
<?php | |||
/** | |||
* Copyright 2011 Adobe | |||
* Copyright 2015 Adobe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 2011
only as the file has been created in 2011 only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@magento run all tests |
Hello @magentoabu, As mentioned here, please also add automated test. Thanks |
Hello @magentoabu, Just a friendly reminder to add an automated test for this PR. Thanks |
@engcom-Hotel I'm working on it |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)