Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevContainer > Node 14 to 18 LTS #4170

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
{
"name": "PWA Studio",
"image": "mcr.microsoft.com/devcontainers/javascript-node:0-14",
"image": "mcr.microsoft.com/devcontainers/javascript-node:0-18",
"containerEnv": {
"NODE_OPTIONS": "--openssl-legacy-provider"
},
"forwardPorts": [10000],
"postCreateCommand": "yarn install --frozen-lockfile && yarn build && yarn workspace @magento/venia-concept run watch",
"postCreateCommand": "yarn install --frozen-lockfile && yarn build",
"postStartCommand": "yarn workspace @magento/venia-concept run watch",
"extensions": [
"larsroettig.vscode-pwa-studio",
"GraphQL.vscode-graphql-syntax"
Expand Down