Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/xcode 10 fix #28

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bug/xcode 10 fix #28

wants to merge 6 commits into from

Conversation

daametsi
Copy link

No description provided.

Airiel Salvatore and Robert Wallis and others added 6 commits June 22, 2018 17:05
fix for xcode 10 adding shaders to project targety
6a495c8
@eduardo3150
Update GLTFUnarchiver.swift
fcea3a9 
comment out loadWeightAnimationsSampler data count mismatch
@genui-voltron
Merge pull request #1 from eduardo3150/patch-2
00926dc 
Update GLTFUnarchiver.swift
@daametsi
fix some weird stuff with shaders
0f24eb0
@daametsi
comment out alpha cutoff
ae4aef8
Fixing animation appending instead of commenting out.
3a07244 
It looks like the code is meant for x,y,z with a stride, but our GLB has only x.
@brentchow
Copy link

brentchow commented Dec 1, 2018 •
edited
Loading

Is this related to #20 ?

@brentchow
Copy link

Following the comment @daametsi left, commenting this out resolved #20 and rendered the model.

GLTFSceneKit/Source/Common/GLTFUnarchiver.swift

Lines 1308 to 1311 in 3a07244

// Comment out to fix animations
guard dataLength == keyTimes.count else {
throw GLTFUnarchiveError.DataInconsistent("loadWeightAnimationsSampler: data count mismatch: \(dataLength) != \(keyTimes.count)")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daametsi @brentchow @eduardo3150 @genui-voltron