-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update contribute docs with correct cli example #509
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes then lgtm
CONTRIBUTING.md
Outdated
</Steps> | ||
|
||
</TabsContent> | ||
|
||
</Tabs> | ||
|
||
<ComponentSource name="example-component" /> | ||
|
||
## Props | ||
|
||
| Prop | Type | Description | Default | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well update the props as well to match the latest format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Will update the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Before
After
Another suggestion is to include the
pnpm format:write
andpnpm lint:fix
commands in the documentation, so that when everyone is making a PR, it is already formatted and linted correctly.