Skip to content

wayland: implement xdg-toplevel-tag-v1 #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

wayland: implement xdg-toplevel-tag-v1 #434

merged 1 commit into from
Apr 22, 2025

Conversation

mahkoh
Copy link
Owner

@mahkoh mahkoh commented Apr 22, 2025

No description provided.

@mahkoh mahkoh requested a review from Copilot April 22, 2025 15:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the new xdg-toplevel-tag-v1 protocol, adding support for tag and description requests for xdg toplevels in the compositor.

  • Added a protocol definition file in wire/xdg_toplevel_tag_manager_v1.txt.
  • Implemented corresponding request handlers and error types in Rust under src/ifs/xdg_toplevel_tag_manager_v1.rs.
  • Registered the new global in the globals and ifs modules, updated release notes, and added documentation.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
wire/xdg_toplevel_tag_manager_v1.txt Defines the protocol requests for destroy, set_toplevel_tag, and set_toplevel_description.
src/ifs/xdg_toplevel_tag_manager_v1.rs Implements the request handling and error type for the new protocol.
src/ifs.rs Registers the new module for the xdg_toplevel_tag_manager_v1.
src/globals.rs Registers the global object singleton for the new protocol.
release-notes.md Adds a note about the implementation of xdg-toplevel-tag-v1.
docs/features.md Documents the new protocol support.
Comments suppressed due to low confidence (1)

src/ifs/xdg_toplevel_tag_manager_v1.rs:27

  • Consider renaming 'XdgTopleveTagManagerV1Error' to 'XdgToplevelTagManagerV1Error' to maintain consistency with the protocol naming in other parts of the code.
fn bind_(self: Rc<Self>, id: XdgToplevelTagManagerV1Id, client: &Rc<Client>, version: Version) -> Result<(), XdgTopleveTagManagerV1Error> {

@mahkoh mahkoh merged commit 1d017ec into master Apr 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant