[WIP] Implement alias grouping, fix #4647 #4655
Draft
+156
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entry `address` is duplicated and can be removed.
ClundXIII
changed the title
|
Could you change the base branch to staging? |
Sure. Is that the preferred way of sending a PR? |
|
Yes :) |
ClundXIII
force-pushed
the
feature-4647-implement-alias-grouping
branch
7 times, most recently
from
0d207fd to
5e42a1b
Compare
This comment adds a new table `alias_group` as well as an `alias_group_id` columnt to the `alias` table. This is the first step, where the alias group does have no other functionality than sorting. TODO: remove commented out map_full --> move to new PR / commit
ClundXIII
force-pushed
the
feature-4647-implement-alias-grouping
branch
from
5e42a1b to
5fd2e6b
Compare
|
Adding / removing to group and display works now. (I manually added the groups into the database) @MAGICCC @DerLinkman where can I find the template for adding a new Alias? It would make a lot of sense to add all the generated alias to a new group with one click. I am currently unsure if an extra page just for alias groups is needed. Can I add the group overview (and edit / delete) Buttons right at the bottom of the alias page? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces grouping of alias together. So far this is the "first stage" where the group has no functionality other than visually and for ordering.
Backend:
UI:
fix #4647
(This is work in progress, also not yet tested.)