feat(gql): (re-)implemented some commits & re-organized gql tests

modules/core/graph/resolvers/commits.js

@@ -9,6 +9,7 @@ const {
   createCommitByBranchId,
   updateCommit,
   deleteCommit,
+  getCommitById,
   getCommitsByBranchId,
   getCommitsByBranchName,
   getCommitsByUserId,
@@ -26,33 +27,59 @@ const {
 module.exports = {
   Query: {},
   Stream: {
+
     async commit( parent, args, context, info ) {
       throw new ApolloError( 'not implemented' )
     }
+
   },
   User: {
+
     async commits( parent, args, context, info ) {
       // TODO
       throw new ApolloError( 'not implemented' )
     }
+
   },
   Branch: {
+
     async commits( parent, args, context, info ) {
       throw new ApolloError( 'not implemented' )
     }
+
   },
   Mutation: {
+
     async commitCreate( parent, args, context, info ) {
-      throw new ApolloError('not implemented')
+      await validateServerRole( context, 'server:user' )
+      await validateScopes( context.scopes, 'streams:write' )
+      await authorizeResolver( context.userId, args.commit.streamId, 'stream:contributor' )
 
+      return await createCommitByBranchName( { ...args.commit, authorId: context.userId } )
     },
+
     async commitUpdate( parent, args, context, info ) {
-      throw new ApolloError('not implemented')
+      await validateServerRole( context, 'server:user' )
+      await validateScopes( context.scopes, 'streams:write' )
+      await authorizeResolver( context.userId, args.commit.streamId, 'stream:contributor' )
+
+      let commit = await getCommitById( { id: args.commit.id } )
+      if ( commit.author !== context.userId )
+        throw new AuthorizationError( 'Only the author of a commit may update it.' )
 
+      return await updateCommit( { ...args.commit } )
     },
+
     async commitDelete( parent, args, context, info ) {
-      throw new ApolloError('not implemented')
-
+      await validateServerRole( context, 'server:user' )
+      await validateScopes( context.scopes, 'streams:write' )
+      await authorizeResolver( context.userId, args.commit.streamId, 'stream:contributor' )
+
+      let commit = await getCommitById( { id: args.commit.id } )
+      if ( commit.author !== context.userId )
+        throw new AuthorizationError( 'Only the author of a commit may delete it.' )
+
+      return await deleteCommit( { id: args.commit.id } )
     }
   }
 }

modules/core/graph/schemas/branchesAndCommits.graphql

@@ -83,8 +83,9 @@ input BranchDeleteInput {
 input CommitCreateInput {
   streamId: String!
   branchName: String!
-  objectReference: String!
+  objectId: String!
   message: String
+  previousCommitIds: [String]
 }
 
 input CommitUpdateInput { 

modules/core/migrations/000-core.js

@@ -147,8 +147,8 @@ exports.up = async knex => {
   // - one ancestor (simple sequential push)
   // - more ancestors (result of a merge)
   await knex.schema.createTable( 'parent_commits', table => {
-    table.string( 'parent', 10 ).references( 'id' ).inTable( 'commits' ).notNullable( )
-    table.string( 'child', 10 ).references( 'id' ).inTable( 'commits' ).notNullable( )
+    table.string( 'parent', 10 ).references( 'id' ).inTable( 'commits' ).notNullable( ).onDelete( 'cascade' )
+    table.string( 'child', 10 ).references( 'id' ).inTable( 'commits' ).notNullable( ).onDelete( 'cascade' )
     table.unique( [ 'parent', 'child' ], 'commit_parent_child_index' )
   } )
 

modules/core/services/streams.js

@@ -33,7 +33,10 @@ module.exports = {
   },
 
   async updateStream( { streamId, name, description } ) {
-    let [ res ] = await Streams( ).returning( 'id' ).where( { id: streamId } ).update( { name, description } )
+    let [ res ] = await Streams( )
+      .returning( 'id' )
+      .where( { id: streamId } )
+      .update( { name, description } )
     return res
   },