Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ [PERF] Delay loading filter form in List Views #312

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Chatewgne
Copy link
Member

@Chatewgne Chatewgne commented Dec 13, 2024

Optimize List View loading by delaying the loading of filtering options.

When a List View opens, the hidden filter form only includes BBOX to maintain map zoom filtering.

When clicking the "Filter" button, the full FilterSet (including BBOX and all other attributes) loads in the pop-up.

⚠️ Breaking change: If you customize the FilterSet, it must be added to: FormatList, Filter, List, and ViewSet

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (c04233a) to head (1edc89e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   91.10%   91.27%   +0.17%     
==========================================
  Files          32       32              
  Lines        2406     2442      +36     
==========================================
+ Hits         2192     2229      +37     
+ Misses        214      213       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne force-pushed the perf_delay_filters branch 10 times, most recently from 868d2bf to eb95d50 Compare December 18, 2024 10:39
@Chatewgne Chatewgne changed the title Delay loading filter form in List Views ⚡ [PERF] Delay loading filter form in List Views Dec 18, 2024
@Chatewgne Chatewgne force-pushed the perf_delay_filters branch 2 times, most recently from 4d47492 to 9cfe563 Compare December 18, 2024 11:37
test_app/filters.py Outdated Show resolved Hide resolved
@Chatewgne Chatewgne force-pushed the perf_delay_filters branch 6 times, most recently from 9004d6d to f185fa4 Compare December 26, 2024 16:22
@Chatewgne Chatewgne marked this pull request as ready for review December 26, 2024 16:23
@Chatewgne Chatewgne force-pushed the perf_delay_filters branch 4 times, most recently from 525ad37 to 070ba44 Compare December 27, 2024 13:22
CHANGES.md Show resolved Hide resolved
docs/customization.rst Outdated Show resolved Hide resolved
docs/customization.rst Show resolved Hide resolved
@Chatewgne Chatewgne force-pushed the perf_delay_filters branch 3 times, most recently from 8209bc1 to 950ac3a Compare January 7, 2025 16:20
mapentity/static/mapentity/mapentity.filter.js Outdated Show resolved Hide resolved
mapentity/static/mapentity/mapentity.filter.js Outdated Show resolved Hide resolved
mapentity/static/mapentity/mapentity.filter.js Outdated Show resolved Hide resolved
mapentity/static/mapentity/mapentity.filter.js Outdated Show resolved Hide resolved
@Chatewgne Chatewgne merged commit 250d616 into master Jan 9, 2025
13 checks passed
@Chatewgne Chatewgne deleted the perf_delay_filters branch January 9, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants