Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using LayerShellQt for the input panel #123

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awhiemstra
Copy link
Contributor

inputpanel-shell is rather limited and doesn't support things like
proper placement and sizing. Fortunately, layer-shell can be used
instead to get support for these. This adds support for using
layer-shell, prefering it over inputpanel-shell. We only need to set
some properties from the Maliit side, most of the actual magic is
taken care of by the compositor.

Most importantly, this makes it possible for the compositor to ensure
Maliit does not overlap panels while at the same time ensuring nothing
ends up out of the screen.

inputpanel-shell is rather limited and doesn't support things like
proper placement and sizing. Fortunately, layer-shell can be used
instead to get support for these. This adds support for using
layer-shell, prefering it over inputpanel-shell. We only need to set
some properties from the Maliit side, most of the actual magic is
taken care of by the compositor.

Most importantly, this makes it possible for the compositor to ensure
Maliit does not overlap panels while at the same time ensuring nothing
ends up out of the screen.
@dobey dobey self-requested a review April 13, 2022 18:25
Copy link
Contributor

@dobey dobey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this not be taken care of by adding the setKeyboardInteractivity and setScope calls here, to the changes in maliit/framework#89 instead?

In fact, I'd rather prefer to get rid of some of the duplicated code we have here in keyboard, and make appropriate fixes in framework so that it can be used for the window configuration instead, as this should work for all maliit plugins, and not just our own keyboard.

@dobey dobey marked this pull request as draft April 26, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants