Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add s3 custom ca support #1338

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add s3 custom ca support #1338

merged 1 commit into from
Apr 12, 2024

Conversation

phoebusm
Copy link
Collaborator

@phoebusm phoebusm commented Feb 16, 2024 •
edited
Loading

Reference Issues/PRs

#1129

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@phoebusm phoebusm added the enhancement New feature or request label Feb 16, 2024
@phoebusm phoebusm self-assigned this Feb 16, 2024
@phoebusm phoebusm force-pushed the feature/s3_custom_ca_file branch 4 times, most recently from 991059c to c11a71e Compare March 4, 2024 10:29
@phoebusm phoebusm force-pushed the feature/s3_custom_ca_file branch 4 times, most recently from a0afb1d to 5a2da87 Compare March 11, 2024 14:39
@phoebusm phoebusm marked this pull request as ready for review March 12, 2024 00:00
@phoebusm phoebusm force-pushed the feature/s3_custom_ca_file branch 2 times, most recently from 8dc1929 to 7c4095c Compare March 12, 2024 00:26
poodlewars
poodlewars reviewed Mar 13, 2024
View reviewed changes
python/arcticdb/adapters/s3_library_adapter.py Outdated Show resolved Hide resolved
python/arcticdb/storage_fixtures/s3.py Outdated Show resolved Hide resolved
python/arcticdb/storage_fixtures/s3.py Show resolved Hide resolved
python/arcticdb/storage_fixtures/s3.py Outdated Show resolved Hide resolved
python/arcticdb/storage_fixtures/s3.py Outdated Show resolved Hide resolved
python/arcticdb/storage_fixtures/s3.py Show resolved Hide resolved
python/arcticdb/storage_fixtures/s3.py Outdated Show resolved Hide resolved
python/tests/conftest.py Outdated Show resolved Hide resolved
python/tests/util/mark.py Outdated Show resolved Hide resolved
python/tests/integration/arcticdb/test_arctic.py Show resolved Hide resolved
@phoebusm phoebusm force-pushed the feature/s3_custom_ca_file branch 3 times, most recently from c3e6552 to 79786f4 Compare March 19, 2024 09:23
@phoebusm phoebusm linked an issue Mar 19, 2024 that may be closed by this pull request
Use HTTPS and SSL in AWS real storage tests #758
Closed
poodlewars
poodlewars reviewed Mar 19, 2024
View reviewed changes
environment_unix.yml Outdated Show resolved Hide resolved
python/arcticdb/storage_fixtures/s3.py Outdated Show resolved Hide resolved
@phoebusm phoebusm force-pushed the feature/s3_custom_ca_file branch 2 times, most recently from a4d3338 to 8a2e29c Compare March 22, 2024 12:48
@phoebusm phoebusm mentioned this pull request Mar 22, 2024
Open
poodlewars
poodlewars approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@poodlewars poodlewars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to do this if we're going to dynamically link openssl?

@phoebusm
Copy link
Collaborator Author

phoebusm commented Apr 8, 2024 •
edited
Loading

Do we still need to do this if we're going to dynamically link openssl?

Yes but lower priority. Still user may still need to use proprietary ca file for verification.

@phoebusm phoebusm merged commit dfb32de into master Apr 12, 2024
113 of 114 checks passed
@phoebusm phoebusm deleted the feature/s3_custom_ca_file branch April 12, 2024 13:24
@phoebusm phoebusm mentioned this pull request Apr 15, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poodlewars poodlewars poodlewars approved these changes

Assignees

@phoebusm phoebusm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use HTTPS and SSL in AWS real storage tests
2 participants
@phoebusm @poodlewars