Add documentation and new constructor (pointer + size) for u8_buffer,… #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 89.52% 89.54% +0.02%
==========================================
Files 91 91
Lines 6693 6708 +15
==========================================
+ Hits 5992 6007 +15
Misses 701 701
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Alex-PLACET
force-pushed
the
u8buffer_improvements
branch
2 times, most recently
from
0e9ca4c to
9d0e306
Compare
Alex-PLACET
requested review from
JohanMabille
and removed request for
DerThorsten and
SylvainCorlay
Alex-PLACET
force-pushed
the
u8buffer_improvements
branch
from
9d0e306 to
a665ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… add operator[] too