Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaks #363

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fix leaks #363

merged 2 commits into from
Feb 28, 2025

Conversation

Alex-PLACET
Copy link
Collaborator

No description provided.

@Alex-PLACET Alex-PLACET self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 86.23853% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (7c3a27f) to head (a199f07).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/arrow_array_schema_proxy.cpp 65.21% 8 Missing ⚠️
src/arrow_interface/private_data_ownership.cpp 73.91% 6 Missing ⚠️
...ow_interface/arrow_array_schema_common_release.hpp 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   89.69%   89.52%   -0.17%     
==========================================
  Files          88       91       +3     
  Lines        6637     6693      +56     
==========================================
+ Hits         5953     5992      +39     
- Misses        684      701      +17     
Flag Coverage Δ
unittests 89.52% <86.23%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-PLACET Alex-PLACET marked this pull request as ready for review February 28, 2025 09:10
@Alex-PLACET Alex-PLACET force-pushed the fix_leaks branch 2 times, most recently from f04e37d to 2a9b811 Compare February 28, 2025 10:27
Copy link
Collaborator

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall implementation looks good to me. I think it would be worth:

  • gathering the children_ownership / dictionary_ownership and arrow_array_schema_common_release in a single file to avoid introducing too many files (private_data_ownership.hpp?)
  • move as much implementation as possible to cpp files to reduce ABI backward incompatible changes in the future.

@Alex-PLACET Alex-PLACET merged commit dbb9b68 into man-group:main Feb 28, 2025
64 of 66 checks passed
@Alex-PLACET Alex-PLACET deleted the fix_leaks branch February 28, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants