Add dictionary c data integration tests #451
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage 88.31% 88.31%
=======================================
Files 96 96
Lines 7314 7314
=======================================
Hits 6459 6459
Misses 855 855
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // ); | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Why commenting this?
There was a problem hiding this comment.
I have to remove it, but the thing is that the dictionary name produced by the C++ implementation doesn't follow the other layout and it's a pain to compare
There was a problem hiding this comment.
If you don't plan to reintroduce it (or reimplement it somehow) this code can be deleted for good.
| @@ -40,8 +40,6 @@ namespace sparrow::c_data_integration | |||
| std::vector<sparrow::array> | |||
| get_children_arrays(const nlohmann::json& array, const nlohmann::json& schema, const nlohmann::json& root); | |||
|
|
|||
| void read_schema_from_json(const nlohmann::json& data); | |||
There was a problem hiding this comment.
Why dropping this one?
There was a problem hiding this comment.
It was unused and useless
Alex-PLACET
force-pushed
the
add_dictionary_c_data_integration_tests
branch
from
f2a5849 to
5d78a0d
Compare
for more information, see https://pre-commit.ci
No description provided.