Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bootstrap-managarm bugs #440

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

pitust
Copy link

@pitust pitust commented Jan 20, 2025

No description provided.

@@ -24,6 +24,7 @@ tools:
- '--enable-gtk'
- '--enable-sdl'
- '--enable-trace-backends=log'
- '--enable-slirp'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong - meson auto-detects libslirp without needing this flag. It only ever gets disabled when it's not present.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, changing configure flags requires a revbump.

Copy link
Author

@pitust pitust Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong - meson auto-detects libslirp without needing this flag. It only ever gets disabled when it's not present.

Weird, it didn't detect it for me (and this fixed it). libslirp is a subproject of qemu, though, so I suspect it's fetched automatically if you ask for it.

Also, changing configure flags requires a revbump.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants