Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REVIUNG39 outboard is slightly behind the REVIUNG41 (it's missing nice_nano_v2.overlay and
MIRYOKU_LAYERS_FLIP
), this change syncs them up.The REVIUNG39 and 41 are almost the same --- you could flash both with the same firmware: reviewing the three ZMK REVIUNG39 PRs (zmkfirmware/zmk#622, zmkfirmware/zmk#695, and zmkfirmware/zmk#795), plus the REVIUNG39 vs. 41 QMK keyboards and the REVIUNG39 vs. 41 KiCad files, the only difference is that keymap positions
RC(6,0)
,RC(6,1)
, andRC(6,2)
vs.RC(6,1)
,RC(6,2)
, andRC(6,3)
are mapped to SPC, ENT, and BSPC. Otherwise they're identical --- they share a common default keymap except for the outer thumbs.So I added a reviung41_39 variant instead of duplicating boards/shields/reviung41 and used a matrix transform to account for the only difference. I repeated the
RC(6,0)
entry:map = <... RC(6,0) RC(6,0) RC(6,1) RC(6,2)>;
, which expands tostatic uint32_t transform[] = {... [36] = 36, [36] = 37, [37] = 38, [38] = 39};
and transforms both boards' thumbs to the same keymap positions.