Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add / Replace Image Stack doesn't allow .fits files #2152

Closed
MikeSullivan7 opened this issue Mar 27, 2024 · 5 comments · Fixed by #2410
Closed

Add / Replace Image Stack doesn't allow .fits files #2152

MikeSullivan7 opened this issue Mar 27, 2024 · 5 comments · Fixed by #2410
Assignees
@ashmeigh
Labels
Type: Bug

Comments

@MikeSullivan7
Copy link
Collaborator

Summary

Loading any extra files through the "Add / Replace Image Stack" dialog does not allow the selection of .fits files

Steps To Reproduce

Open MI and load data, then right click the data stack on the tree on the left and click "Add / Replace Stack". Clicking the "Choose File" button only allows .tif and .tiff files to be selected.

Expected Behaviour

The "Add / Replace Stack" should be able to load the same file types as the main Load Dataset file dialog.

Current Behaviour

Only .tif and .tiff files can be loaded though the "Add / Replace Stack" file dialog
@samtygier-stfc samtygier-stfc moved this from Todo to In Progress in Mantid Imaging Work Jul 10, 2024
@samtygier-stfc samtygier-stfc moved this from In Progress to Todo in Mantid Imaging Work Jul 10, 2024
@MikeSullivan7 MikeSullivan7 self-assigned this Jul 15, 2024
@MikeSullivan7
Copy link
Collaborator Author

It seems that the "Add / Replace Image Stack" dialog doesn't work at all anymore, even with .tif or .tiff files.

2024-08-15 15:02:35,090 [mantidimaging.gui.windows.main.view:L589] ERROR: Traceback (most recent call last):
  File "C:\Users\ddb29996\mantidimaging\mantidimaging\gui\windows\add_images_to_dataset_dialog\view.py", line 37, in _on_accepted
    self.presenter.notify(Notification.IMAGE_FILE_SELECTED)
  File "C:\Users\ddb29996\mantidimaging\mantidimaging\gui\windows\add_images_to_dataset_dialog\presenter.py", line 29, in notify
    self.load_images()
  File "C:\Users\ddb29996\mantidimaging\mantidimaging\gui\windows\add_images_to_dataset_dialog\presenter.py", line 37, in load_images
    start_async_task_view(self.view, self.view.parent_view.presenter.model.load_image_stack,
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'MainWindowModel' object has no attribute 'load_image_stack'

@MikeSullivan7
Copy link
Collaborator Author

It seems like this has been broken as far back as release-2.7.0 which is confusing as I thought this would be caught in manual testing...

@MikeSullivan7
Copy link
Collaborator Author

The error is still showing in release-2.6.0 after rebuilding the dev environment (after swapping out the old intel channel)

@samtygier-stfc
Copy link
Collaborator

samtygier-stfc commented Aug 15, 2024 •
edited
Loading

#2317 is the fix for Add/Replace on an open dataset, which has been broken for a while.

The File->Load Images method (which makes a new dataset with the new stack) works for tif but not for fits. That's probably the method that this issue should be about. Though it would be good to fix both methods.

@MikeSullivan7 MikeSullivan7 removed their assignment Aug 15, 2024
@JackEAllen
Copy link
Collaborator

This may be related to and solve: #2397

@samtygier-stfc samtygier-stfc mentioned this issue Nov 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mantid Imaging Work Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashmeigh ashmeigh

Labels
Type: Bug
Projects
Mantid Imaging Work
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added fits file to choose file path mantidproject/mantidimaging
4 participants
@MikeSullivan7 @JackEAllen @ashmeigh @samtygier-stfc