Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fits file to choose file path #2410

Merged
merged 3 commits into from
Nov 28, 2024
Merged

added fits file to choose file path #2410

merged 3 commits into from
Nov 28, 2024

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Nov 20, 2024

Issue

Closes #2152

Description

Updated the choose_file_path method to include support for .fits files in addition to .tif and .tiff.
Modified the file dialog filter to Image Files (*.tif *.tiff *.fits) to allow users to select .fits files alongside existing formats.

Testing

Opened the file dialog to ensure .tif, .tiff, and .fits files are selectable.
Verified that selecting a .fits file updates the file path text field and enables the "OK" button.
Confirmed behavior remains consistent when selecting .tif or .tiff files.

@coveralls
Copy link

coveralls commented Nov 21, 2024

Coverage Status

coverage: 74.172% (-0.05%) from 74.22%
when pulling 545aa0c on 2152-fits-files
into 45a56d1 on main.

@samtygier-stfc
Copy link
Collaborator Author

samtygier-stfc commented Nov 21, 2024

Needs a release note entry

@ashleymeigh2
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 marked this pull request as ready for review November 28, 2024 16:20
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like its working properly, I can load in .fits data just like .tiff in the main window.

@MikeSullivan7 MikeSullivan7 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit e2bbcf4 Nov 28, 2024
8 checks passed
@MikeSullivan7 MikeSullivan7 deleted the 2152-fits-files branch November 28, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add / Replace Image Stack doesn't allow .fits files
5 participants