Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute NaN Function #2086

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Compute NaN Function #2086

merged 3 commits into from
Mar 8, 2024

Conversation

ashmeigh
Copy link
Collaborator

@ashmeigh ashmeigh commented Mar 4, 2024

Description
This pull request addresses the ongoing effort to standardize the execution of operations by transitioning from the partial function style to a structured compute_function approach. In this update, several operations have been refactored to adhere to the new standard. The modifications ensure a clearer separation between the setup and execution phases of each operation, improving the maintainability and readability of the codebase.

Changes made
Refactored multiple operations to implement the new compute_function approach.
Introduced static methods compute_function in each affected operation module to encapsulate the core logic for executing the operation on a per-slice basis.
Updated the calling code to use the compute_function method instead of the previous partial function style

@coveralls
Copy link

coveralls commented Mar 4, 2024

Coverage Status

coverage: 74.385% (+0.03%) from 74.359%
when pulling e6f0eef on NaN_compute_1
into e82455a on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move the

if mode_value == "Constant":
    ...
else ... :
    ...

in to filter_func(), and then call separate compute functions.

That would mean we only need to check once, and can raise the value error once from outside the compute function.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 589ecfc Mar 8, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the NaN_compute_1 branch March 8, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants