Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eyes_test GitHub actions #2153

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix eyes_test GitHub actions #2153

merged 1 commit into from
Mar 27, 2024

Conversation

MikeSullivan7
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 commented Mar 27, 2024

Description

The eyes tests have not been running on GitHub Actions as the --run-eyes-tests flag was not added to the Windows and Conda work flows. This PR adds those flags so the applitools tests will now run!

@coveralls
Copy link

Coverage Status

coverage: 74.298%. remained the same
when pulling ea736df on Flash_PR_eyes_fix
into d0b5a3b on main.

@MikeSullivan7 MikeSullivan7 marked this pull request as ready for review March 27, 2024 12:17
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit eb6ca8f Mar 27, 2024
10 checks passed
@samtygier-stfc samtygier-stfc deleted the Flash_PR_eyes_fix branch March 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants