-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Live Viewers can be opened simultaneously #2398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
Nov 14, 2024
MikeSullivan7
force-pushed
the
2361_multiple_LV_windows
branch
from
November 19, 2024 11:15
d7d37ae
to
1a9589c
Compare
samtygier-stfc
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. A couple of small tweaks.
eyes test fix small fixes
MikeSullivan7
force-pushed
the
2361_multiple_LV_windows
branch
from
November 20, 2024 10:29
1a9589c
to
4168685
Compare
samtygier-stfc
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2361
Description
Removed the reraising of the currently opened Live Viewer to allow a second (or more) Live Viewer to be opened, each with a specified path.
Testing
make check
make system-test
Acceptance Criteria
Open multiple Live Viewer windows and point them to different directories. Check that the LVs behave independently of each other and behave as expected. You should be able to use multiple terminals with the
simulate_live_data.py
script to check that MI can process the various LVs simultaneously (see screenshot below)Documentation
Add release note