Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Live Viewers can be opened simultaneously #2398

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

MikeSullivan7
Copy link
Collaborator

Issue

Closes #2361

Description

Removed the reraising of the currently opened Live Viewer to allow a second (or more) Live Viewer to be opened, each with a specified path.

Testing

make check
make system-test

Acceptance Criteria

Open multiple Live Viewer windows and point them to different directories. Check that the LVs behave independently of each other and behave as expected. You should be able to use multiple terminals with the simulate_live_data.py script to check that MI can process the various LVs simultaneously (see screenshot below)

Documentation

Add release note

image

@coveralls
Copy link

coveralls commented Nov 13, 2024

Coverage Status

coverage: 74.229% (+0.009%) from 74.22%
when pulling 4168685 on 2361_multiple_LV_windows
into 45a56d1 on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A couple of small tweaks.

mantidimaging/gui/windows/main/view.py Outdated Show resolved Hide resolved
mantidimaging/gui/windows/main/view.py Outdated Show resolved Hide resolved
eyes test fix

small fixes
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 700e3e8 Nov 21, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2361_multiple_LV_windows branch November 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opening multiple live viewers
3 participants