Refactor get_spectrum to no longer accept ROI as a string #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
Nov 27, 2024
ashmeigh
force-pushed
the
get_spectum_remove_string
branch
from
8e6df61
to
5312953
Compare
ashmeigh
force-pushed
the
get_spectum_remove_string
branch
from
5312953
to
beb7bb6
Compare
samtygier-stfc
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2297
Description
Refactored get_spectrum to only accept SensibleROI objects. Updated all dependent methods (do_add_roi, do_remove_roi, redraw_spectrum, etc.) to retrieve and pass SensibleROI instead of strings.
Testing
updated unit test
Acceptance Criteria
Ran unit tests for methods like do_add_roi, do_remove_roi, redraw_spectrum, and redraw_all_rois to confirm they function correctly with the updated get_spectrum.
Manually tested adding, removing, and updating ROIs in the UI to validate proper behavior.