Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

864: Ops window, image selector in preview section skips by 2 #877

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

DolicaAkelloEgwel
Copy link
Collaborator

@DolicaAkelloEgwel DolicaAkelloEgwel commented Mar 2, 2021

Issue

Closes #864

Description

Disables then enables the spin box while the operation preview is being generated.

Testing

Added a test to check that setEnabled is called twice when the preview is generated.

Acceptance Criteria

Change the preview index value with the left-mouse button and check that the value only increases once for the operations mentioned in #864

Documentation

Updated the release notes.

@DolicaAkelloEgwel DolicaAkelloEgwel changed the title disabling and enabling spin box 864: Ops window, image selector in preview section skips by 2 Mar 2, 2021
@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as ready for review March 2, 2021 17:47
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fixes the issue for me.

@samtygier-stfc samtygier-stfc merged commit aa0938f into master Mar 3, 2021
@samtygier-stfc samtygier-stfc deleted the 864_spinbox_skips_by_2 branch March 3, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ops window, image selector in preview section skips by 2
2 participants