Skip to content

Commit

Permalink
Fix small spec inconsistencies with model types (#12968)
Browse files Browse the repository at this point in the history
- Provide a default value of `""` for `model-id`
- Change `model-emissive-strength` unit value to `intensity`
  • Loading branch information
tristen authored Nov 13, 2023
1 parent 466ee28 commit abbc512
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/style-spec/reference/v8.json
Original file line number Diff line number Diff line change
Expand Up @@ -1269,6 +1269,7 @@
},
"model-id": {
"type": "string",
"default": "",
"doc": "Model to render.",
"property-type": "data-driven",
"expression": {
Expand Down Expand Up @@ -8450,7 +8451,7 @@
"default": 0.0,
"minimum": 0,
"maximum": 5,
"units": "number",
"units": "intensity",
"doc": "Strength of the emission. There is no emission for value 0. For value 1.0, only emissive component (no shading) is displayed and values above 1.0 produce light contribution to surrounding area, for some of the parts (e.g. doors). Expressions that depend on measure-light are not supported when using GeoJSON or vector tile as the model layer source.",
"expression": {
"interpolated": true,
Expand Down

0 comments on commit abbc512

Please sign in to comment.