Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLJS-529] Replace lights requirement in property doc with requires #12896

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[GLJS-529] Replace lights requirement in property doc with requires #12896

merged 1 commit into from
Oct 24, 2023

Conversation

tristen
Copy link
Member

@tristen tristen commented Sep 19, 2023

requires seems to only be used against properties the layer type owns but proposing in this PR to add

"requires": [
  "lights"
  // ...
]

To any properties that require this root property to be set for things to work.

@tristen tristen requested a review from a team as a code owner September 19, 2023 16:24
@A8Starkov A8Starkov changed the title Replace lights requirement in property doc with requires [GLJS-529] Replace lights requirement in property doc with requires Oct 20, 2023
@mourner mourner added the skip changelog Used for PRs that do not need a changelog entry label Oct 23, 2023
@mourner mourner merged commit 19a28a1 into main Oct 24, 2023
5 of 6 checks passed
@mourner mourner deleted the require-lights-on-lights-dependent-properties branch October 24, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepankuzmin stepankuzmin stepankuzmin approved these changes

Assignees
No one assigned
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristen @stepankuzmin @mourner